netdev - Re: Re: stmmac driver...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2016 13:14:47 +0100
From:   Niklas Cassel <niklas.cassel@...s.com>
To:     Jie Deng <Jie.Deng1@...opsys.com>,
        Niklas Cassel <nks.gnu@...il.com>
CC:     David Miller <davem@...emloft.net>, <alexandre.torgue@...com>,
        <peppe.cavallaro@...com>, <netdev@...r.kernel.org>,
        <CARLOS.PALMINHA@...opsys.com>, <Joao.Pinto@...opsys.com>
Subject: Re: Re: stmmac driver...

(resend with netdev included)

On 12/09/2016 05:29 PM, Jie Deng wrote:
>
> On 2016/12/9 18:50, Niklas Cassel wrote:
>> Hello Jie Deng
>>
>>
>> In your cover letter you wrote
>>
>> dwc-eth-xxx.x
>>   The DWC ethernet core layer (DWC ECL). This layer contains codes
>> can be shared by different DWC series ethernet cores
>>
>> Does this mean that code in dwc-eth-xxx.x is common to all
>> the different Synopsys IPs, GMAC, XGMAC and XLGMAC ?
>>
>>
>> Regards,
>> Niklas
> Yeah,  these codes may be reused in the future (due to HW similarities) but it
> would require a lot of refactoring. For the moment I will focus on the driver
> only for XLGMAC.

Ok, thank you for the clarification.

>
> XLGMAC is Synopsys "Enterprise MAC" controller (the product is already public):
> https://www.synopsys.com/dw/ipdir.php?ds=dwc_ether_enterprise_mac
>
> What do you think following strategy:
> - GMAC (QoS): discard drivers/net/ethernet/synopsys/dwc_eth_qos.c and keep
> development under drivers/net/ethernet/stmicro/stmmac/
> - XGMAC: keep development under drivers/net/ethernet/amd/xgbe/
> - XLGMAC: do development under drivers/net/ethernet/synopsys/

I don't have an opinion regarding XLGMAC.

For GMAC, I think it's a good idea that everybody focuses on the same driver (stmmac).
The same thing applies to XGMAC, amd-xgbe and sxgbe, however there I don't know
of any consolidation efforts.

>
> Thanks,
> Jie
>
>> On Fri, Dec 9, 2016 at 11:05 AM, Jie Deng <Jie.Deng1@...opsys.com> wrote:
>>> On 2016/12/8 23:25, David Miller wrote:
>>>> From: Alexandre Torgue <alexandre.torgue@...com>
>>>> Date: Thu, 8 Dec 2016 14:55:04 +0100
>>>>
>>>>> Maybe I forget some series. Do you have others in mind ?
>>>> Please see the thread titled:
>>>>
>>>> "net: ethernet: Initial driver for Synopsys DWC XLGMAC"
>>>>
>>>> which seems to be discussing consolidation of various drivers
>>>> for the same IP core, of which stmmac is one.
>>>>
>>>> I personally am against any change of the driver name and
>>>> things like this, and wish the people doing that work would
>>>> simply contribute to making whatever changes they need directly
>>>> to the stmmac driver.
>>>>
>>>> You really need to voice your opinion when major changes are being
>>>> proposed for the driver you maintain.
>>>>
>>> Hi David and Alex,
>>>
>>> XLGMAC is not a version of GMAC. Synopsys has several IPs and each IP has
>>> several versions.
>>>
>>> GMAC(QoS): 3.5, 3.7, 4.0, 4.10, 4.20...
>>> XGMAC: 1.00, 1.10, 1.20, 2.00, 2.10, 2.11...
>>> XLGMAC (Synopsys DesignWare Core Enterprise Ethernet): this is a new IP.
>>>
>>> Regards,
>>> Jie
>>>
>