netdev - Re: [PATCH net v3] ibmveth: set correct gso_size and gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Dec 2016 09:49:16 -0600
From:   Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, brking@...ux.vnet.ibm.com,
        marcelo.leitner@...il.com, pradeeps@...ux.vnet.ibm.com,
        jmaxwell37@...il.com, zdai@...ibm.com, eric.dumazet@...il.com
Subject: Re: [PATCH net v3] ibmveth: set correct gso_size and gso_type

On 12/10/2016 02:56 PM, David Miller wrote:
> From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
> Date: Sat, 10 Dec 2016 12:39:48 -0600
>
>> v3: include a check for non-zero mss when calculating gso_segs
>>
>> v2: calculate gso_segs after Eric Dumazet's comments on the earlier patch
>>     and make sure everyone is included on CC
> I already applied v1 which made it all the way even to Linus's
> tree.  So you'll have to send me relative fixups if there are
> things to fix or change since v1.
>
> You must always generate patches against the current 'net' tree.
>
Sorry about that.  Thank you for applying it on short notice.  I agree that using the TCP checksum field is not ideal, but it was a compromise with the VIOS team.  Hopefully, there will be a better way in the future.

Thanks again,

Tom