netdev - RE: [PATCH net-next 07/27] gianfar: remove use of VLAN_TAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM5PR0401MB2561A8DC4A63BCB292717B69969B0@AM5PR0401MB2561.eurprd04.prod.outlook.com>
Date:   Tue, 13 Dec 2016 12:09:25 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 07/27] gianfar: remove use of VLAN_TAG_PRESENT

>-----Original Message-----
>From: Michał Mirosław [mailto:mirq-linux@...e.qmqm.pl]
>Sent: Tuesday, December 13, 2016 2:13 AM
>To: netdev@...r.kernel.org
>Cc: Claudiu Manoil <claudiu.manoil@...escale.com>
>Subject: [PATCH net-next 07/27] gianfar: remove use of VLAN_TAG_PRESENT
>
>Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
>---
> drivers/net/ethernet/freescale/gianfar_ethtool.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c
>b/drivers/net/ethernet/freescale/gianfar_ethtool.c
>index 56588f2..95fa647 100644
>--- a/drivers/net/ethernet/freescale/gianfar_ethtool.c
>+++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c
>@@ -1155,11 +1155,9 @@ static int gfar_convert_to_filer(struct
>ethtool_rx_flow_spec *rule,
> 		prio = vlan_tci_prio(rule);
> 		prio_mask = vlan_tci_priom(rule);
>
>-		if (cfi == VLAN_TAG_PRESENT && cfi_mask ==
>VLAN_TAG_PRESENT) {
>-			vlan |= RQFPR_CFI;
>-			vlan_mask |= RQFPR_CFI;
>-		} else if (cfi != VLAN_TAG_PRESENT &&
>-			   cfi_mask == VLAN_TAG_PRESENT) {
>+		if (cfi_mask) {
>+			if (cfi)
>+				vlan |= RQFPR_CFI;
> 			vlan_mask |= RQFPR_CFI;
> 		}
> 	}

Reviewed-by: Claudiu Manoil <claudiu.manoil@....com>