netdev - Re: [PATCH iproute2 -net-next] lwt: BPF support for LWT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161212154134.51638dae@xeon-e3>
Date:   Mon, 12 Dec 2016 15:41:34 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     tgraf@...g.ch, alexei.starovoitov@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 -net-next] lwt: BPF support for LWT

On Mon, 12 Dec 2016 01:14:35 +0100
Daniel Borkmann <daniel@...earbox.net> wrote:

> +
> +static int lwt_parse_bpf(struct rtattr *rta, size_t len, int *argcp, char ***argvp,
> +			 int attr, const enum bpf_prog_type bpf_type)

Please break long lines like this.


> +
> +	/* argv is currently the first unparsed argument,
> +	 * but the lwt_parse_encap() caller will move to the next,
> +	 * so step back */
> +	*argcp = argc + 1;

iproute2 uses kernel comment style. 

I went ahead and fixed these.