netdev - Re: [PATCH net] ibmveth: calculate gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161214203904.GA13422@localhost.localdomain>
Date:   Wed, 14 Dec 2016 18:39:04 -0200
From:   marcelo.leitner@...il.com
To:     Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
Cc:     netdev@...r.kernel.org, brking@...ux.vnet.ibm.com,
        pradeeps@...ux.vnet.ibm.com, jmaxwell37@...il.com, zdai@...ibm.com,
        eric.dumazet@...il.com
Subject: Re: [PATCH net] ibmveth: calculate gso_segs for large packets

On Tue, Dec 13, 2016 at 06:15:09PM -0600, Thomas Falcon wrote:
> Include calculations to compute the number of segments
> that comprise an aggregated large packet.
> 
> Signed-off-by: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>

Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>


> ---
>  drivers/net/ethernet/ibm/ibmveth.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
> index fbece63..a831f94 100644
> --- a/drivers/net/ethernet/ibm/ibmveth.c
> +++ b/drivers/net/ethernet/ibm/ibmveth.c
> @@ -1181,7 +1181,9 @@ static netdev_tx_t ibmveth_start_xmit(struct sk_buff *skb,
>  
>  static void ibmveth_rx_mss_helper(struct sk_buff *skb, u16 mss, int lrg_pkt)
>  {
> +	struct tcphdr *tcph;
>  	int offset = 0;
> +	int hdr_len;
>  
>  	/* only TCP packets will be aggregated */
>  	if (skb->protocol == htons(ETH_P_IP)) {
> @@ -1208,14 +1210,20 @@ static void ibmveth_rx_mss_helper(struct sk_buff *skb, u16 mss, int lrg_pkt)
>  	/* if mss is not set through Large Packet bit/mss in rx buffer,
>  	 * expect that the mss will be written to the tcp header checksum.
>  	 */
> +	tcph = (struct tcphdr *)(skb->data + offset);
>  	if (lrg_pkt) {
>  		skb_shinfo(skb)->gso_size = mss;
>  	} else if (offset) {
> -		struct tcphdr *tcph = (struct tcphdr *)(skb->data + offset);
> -
>  		skb_shinfo(skb)->gso_size = ntohs(tcph->check);
>  		tcph->check = 0;
>  	}
> +
> +	if (skb_shinfo(skb)->gso_size) {
> +		hdr_len = offset + tcph->doff * 4;
> +		skb_shinfo(skb)->gso_segs =
> +				DIV_ROUND_UP(skb->len - hdr_len,
> +					     skb_shinfo(skb)->gso_size);
> +	}
>  }
>  
>  static int ibmveth_poll(struct napi_struct *napi, int budget)
> -- 
> 1.8.3.1
>