netdev - Re: [PATCH] net: ipv4: tcp_offload: check segs for NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161215134315.GE5816@distanz.ch>
Date:   Thu, 15 Dec 2016 14:43:17 +0100
From:   Tobias Klauser <tklauser@...tanz.ch>
To:     shakya.das@...sung.com
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        shakya89.das@...il.com, vidushi.koul@...sung.com
Subject: Re: [PATCH] net: ipv4: tcp_offload: check segs for NULL

On 2016-12-15 at 09:47:41 +0100, shakya.das@...sung.com <shakya.das@...sung.com> wrote:
> From: Shakya Sundar Das <shakya.das@...sung.com>
> 
> This patch will check segs for being NULL in tcp_gso_segment()
> before calling skb_shinfo(segs) from skb_is_gso(segs), otherwise
> kernel can run into a NULL-pointer dereference.

How can segs ever be NULL here? skb_segment() will always either return
an skb or an ERR_PTR(err).