lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Dec 2016 00:56:24 -0800 From: Christoph Hellwig <hch@...radead.org> To: "Vishwanathapura, Niranjana" <niranjana.vishwanathapura@...el.com> Cc: dledford@...hat.com, linux-rdma@...r.kernel.org, netdev@...r.kernel.org, dennis.dalessandro@...el.com, ira.weiny@...el.com Subject: Re: [RFC v2 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface On Thu, Dec 15, 2016 at 12:53:49AM -0800, Vishwanathapura, Niranjana wrote: > On Wed, Dec 14, 2016 at 11:59:34PM -0800, Vishwanathapura, Niranjana wrote: > > + > > +static inline bool is_hfi_ibdev(struct ib_device *ibdev) > > +{ > > + return !memcmp(ibdev->name, "hfi", 3); > > +} > > I am thinking of adding a device capability flag to indicate HFI VNIC > capabilty instead of relying on the device name as above to identify a hfi > ib deice. Absolutely. > Any comments? Probably it can be addressed by a separate patch later. no, comparing device names is always wrong, please do it ASAP.
Powered by blists - more mailing lists