netdev - Re: [PATCH net] bpf, test_verifier: fix a test case error result on unprivileged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5851E746.9090604@fb.com>
Date:   Wed, 14 Dec 2016 16:43:50 -0800
From:   Alexei Starovoitov <ast@...com>
To:     Daniel Borkmann <daniel@...earbox.net>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH net] bpf, test_verifier: fix a test case error result on
 unprivileged

On 12/14/16 4:39 PM, Daniel Borkmann wrote:
> Running ./test_verifier as unprivileged lets 1 out of 98 tests fail:
>
>    [...]
>    #71 unpriv: check that printk is disallowed FAIL
>    Unexpected error message!
>    0: (7a) *(u64 *)(r10 -8) = 0
>    1: (bf) r1 = r10
>    2: (07) r1 += -8
>    3: (b7) r2 = 8
>    4: (bf) r3 = r1
>    5: (85) call bpf_trace_printk#6
>    unknown func bpf_trace_printk#6
>    [...]
>
> The test case is correct, just that the error outcome changed with
> ebb676daa1a3 ("bpf: Print function name in addition to function id").
> Same as with e00c7b216f34 ("bpf: fix multiple issues in selftest suite
> and samples") issue 2), so just fix up the function name.
>
> Fixes: ebb676daa1a3 ("bpf: Print function name in addition to function id")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

was thinking to send the same fix. Thanks you for beating me :)
Acked-by: Alexei Starovoitov <ast@...nel.org>