netdev - Re: sanity checking iov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2016 10:00:47 +0100
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     brouer@...hat.com, netdev@...r.kernel.org,
        David Miller <davem@...emloft.net>
Subject: Re: sanity checking iov_iter patches

On Thu, 15 Dec 2016 06:23:05 +0000
Al Viro <viro@...IV.linux.org.uk> wrote:

> 	Some of the vfs.git#work.iov_iter stuff touches net/*; basically,
> there are several missing primitives (copy_from_iter_full(), etc.) for
> "try to copy, tell whether it has copied the full amount requested and
> advance the iterator only in case of success".  Most of the callers were
> actually doing just that (see e.g. skb_add_data() and friends) and while
> nothing in the current kernel cares whether we advance ->msg_iter on
> failure, it's much more consistent semantics.
> 
> 	If anybody has objections to that stuff (in linux-next, or in
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git#work.iov_iter),
> or thinks that some of that should go via net-next.git, yell and I'll
> drop the bits in question.  If not, to Linus it all goes...

Just some links to make it quicker for people see the three patches:
 http://git.kernel.org/cgit/linux/kernel/git/viro/vfs.git/log/?h=work.iov_iter

Patches:
 http://git.kernel.org/cgit/linux/kernel/git/viro/vfs.git/commit/?h=work.iov_iter&id=cbbd26b8b1a
 http://git.kernel.org/cgit/linux/kernel/git/viro/vfs.git/commit/?h=work.iov_iter&id=15e6cb46c9b
 http://git.kernel.org/cgit/linux/kernel/git/viro/vfs.git/commit/?h=work.iov_iter&id=0b62fca2623

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer