netdev - Re: [PATCH 1/1] tools: net: bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96578fd4-dd02-f39a-a252-c37aa714d3d0@cogentembedded.com>
Date:   Fri, 16 Dec 2016 22:08:17 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Ozgur Karatas <okaratas@...ber.fsf.org>,
        David Miller <davem@...emloft.net>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo

Hello.

On 12/16/2016 09:21 PM, Ozgur Karatas wrote:

> This patch fixed to keyboard typo, brackets not closed.
> I think, it should be close to parenthes.
>
> Signed-off-by: Ozgur Karatas <okaratas@...ber.fsf.org>
> ---
>  tools/net/bpf_dbg.c       | 2 +-
>  1 files changed, 1 insertion(+), 1 deletions(-)
>
> diff --git a/tools/net/bpf_dbg.c b/tools/net/bpf_dbg.c
> index 4f254bc..f715f46 100644
> --- a/tools/net/bpf_dbg.c
> +++ b/tools/net/bpf_dbg.c
> @@ -1213,7 +1213,7 @@ static int cmd_disassemble(char *line_string)
>
>  	if (!bpf_prog_loaded())
>  		return CMD_ERR;
> -	if (strlen(line_string) > 0 &&
> +	if (strlen(line_string) > 0 &&)

    Have tried to you compile that? :-/

>  	    (line = strtoul(line_string, NULL, 10)) < bpf_prog_len)

    I think the code was correct before your patch...

>  		single_line = true;
>  	if (single_line)

MBR, Sergei