netdev - Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHmME9ruYEJbLOij9ooYxLNgkOfr6F9c87dJjD3D_aFVsEFJZQ@mail.gmail.com>
Date:   Fri, 16 Dec 2016 18:09:26 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     David Laight <David.Laight@...lab.com>
Cc:     George Spelvin <linux@...encehorizons.net>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "ebiggers3@...il.com" <ebiggers3@...il.com>,
        "hannes@...essinduktion.org" <hannes@...essinduktion.org>,
        "jeanphilippe.aumasson@...il.com" <jeanphilippe.aumasson@...il.com>,
        "kernel-hardening@...ts.openwall.com" 
        <kernel-hardening@...ts.openwall.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "luto@...capital.net" <luto@...capital.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tom@...bertland.com" <tom@...bertland.com>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        "tytso@....edu" <tytso@....edu>,
        "vegard.nossum@...il.com" <vegard.nossum@...il.com>,
        "djb@...yp.to" <djb@...yp.to>
Subject: Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

Hi David,

On Fri, Dec 16, 2016 at 6:06 PM, David Laight <David.Laight@...lab.com> wrote:
> A 32bit hash would also remove all the issues about the alignment
> of IP addresses (etc) on 64bit systems.

The current replacements of md5_transform with siphash in the v6 patch
series will continue to use the original siphash, since the 128-bit
key is rather important for these kinds of secrets. Additionally,
64-bit siphash is already faster than the md5_transform that it
replaces. So the alignment concerns (now, non-issues; problems have
been solved, I believe) still remain.

Jason