netdev - Re: [PATCH] bpf: cgroup: annotate pointers in struct cgroup_bpf with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161216182036.GB80546@ast-mbp.thefacebook.com>
Date:   Fri, 16 Dec 2016 10:20:37 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Daniel Mack <daniel@...que.org>
Cc:     ast@...com, daniel@...earbox.net, netdev@...r.kernel.org,
        davem@...emloft.net
Subject: Re: [PATCH] bpf: cgroup: annotate pointers in struct cgroup_bpf with
 __rcu

On Thu, Dec 15, 2016 at 10:53:21AM +0100, Daniel Mack wrote:
> The member 'effective' in 'struct cgroup_bpf' is protected by RCU.
> Annotate it accordingly to squelch a sparse warning.
> 
> Signed-off-by: Daniel Mack <daniel@...que.org>

Acked-by: Alexei Starovoitov <ast@...nel.org>

was only wondering whether this is really needed for net or can wait till net-next.

> ---
>  include/linux/bpf-cgroup.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h
> index 7b6e5d1..92bc89a 100644
> --- a/include/linux/bpf-cgroup.h
> +++ b/include/linux/bpf-cgroup.h
> @@ -20,7 +20,7 @@ struct cgroup_bpf {
>  	 * when this cgroup is accessed.
>  	 */
>  	struct bpf_prog *prog[MAX_BPF_ATTACH_TYPE];
> -	struct bpf_prog *effective[MAX_BPF_ATTACH_TYPE];
> +	struct bpf_prog __rcu *effective[MAX_BPF_ATTACH_TYPE];
>  };
>  
>  void cgroup_bpf_put(struct cgroup *cgrp);
> -- 
> 2.9.3
>