netdev - Re: [PATCH net] net: vrf: Drop conntrack data after pass through VRF device on Tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161217.104844.318907325452419548.davem@davemloft.net>
Date:   Sat, 17 Dec 2016 10:48:44 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsa@...ulusnetworks.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net: vrf: Drop conntrack data after pass through
 VRF device on Tx

From: David Ahern <dsa@...ulusnetworks.com>
Date: Wed, 14 Dec 2016 14:31:11 -0800

> Locally originated traffic in a VRF fails in the presence of a POSTROUTING
> rule. For example,
> 
>     $ iptables -t nat -A POSTROUTING -s 11.1.1.0/24  -j MASQUERADE
>     $ ping -I red -c1 11.1.1.3
>     ping: Warning: source address might be selected on device other than red.
>     PING 11.1.1.3 (11.1.1.3) from 11.1.1.2 red: 56(84) bytes of data.
>     ping: sendmsg: Operation not permitted
> 
> Worse, the above causes random corruption resulting in a panic in random
> places (I have not seen a consistent backtrace).
> 
> Call nf_reset to drop the conntrack info following the pass through the
> VRF device.  The nf_reset is needed on Tx but not Rx because of the order
> in which NF_HOOK's are hit: on Rx the VRF device is after the real ingress
> device and on Tx it is is before the real egress device. Connection
> tracking should be tied to the real egress device and not the VRF device.
> 
> Fixes: 8f58336d3f78a ("net: Add ethernet header for pass through VRF device")
> Fixes: 35402e3136634 ("net: Add IPv6 support to VRF device")
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>

Applied and queued up for -stable.