netdev - Re: [PATCH v3 net] r6040: move spinlock in r6040_close as SOFTIRQ-unsafe lock order detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161217.213630.371461596447265670.davem@davemloft.net>
Date:   Sat, 17 Dec 2016 21:36:30 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     manuel.bessler@...sus.com
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH v3 net] r6040: move spinlock in r6040_close as
 SOFTIRQ-unsafe lock order detected

From: Manuel Bessler <manuel.bessler@...sus.com>
Date: Thu, 15 Dec 2016 22:55:00 -0500

> 'ifconfig eth0 down' makes r6040_close() trigger:
>  INFO: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected
> 
> Fixed by moving calls to phy_stop(), napi_disable(), netif_stop_queue()
> to outside of the module's private spin_lock_irq block.
> 
> Found on a Versalogic Tomcat SBC with a Vortex86 SoC
 ...
> Signed-off-by: Manuel Bessler <manuel.bessler@...sus.com>

Applied, thanks.