netdev - Re: [patch net] mlxsw: spectrum: Mark split ports as such

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161217.214511.989596544518526060.davem@davemloft.net>
Date:   Sat, 17 Dec 2016 21:45:11 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, eladr@...lanox.com,
        yotamg@...lanox.com, nogahf@...lanox.com, arkadis@...lanox.com,
        tamirw@...lanox.com
Subject: Re: [patch net] mlxsw: spectrum: Mark split ports as such

From: Jiri Pirko <jiri@...nulli.us>
Date: Fri, 16 Dec 2016 19:29:03 +0100

> From: Ido Schimmel <idosch@...lanox.com>
> 
> When a port is split we should mark it as such, as otherwise the split
> ports aren't renamed correctly (e.g. sw1p3 -> sw1p3s1) and the unsplit
> operation fails:
> 
> $ devlink port split sw1p3 count 4
> $ devlink port unsplit eth0
> devlink answers: Invalid argument
> [  598.565307] mlxsw_spectrum 0000:03:00.0 eth0: Port wasn't split
> 
> Fixes: 67963a33b4fd ("mlxsw: Make devlink port instances independent of spectrum/switchx2 port instances")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reported-by: Tamir Winetroub <tamirw@...lanox.com>
> Reviewed-by: Elad Raz <eladr@...lanox.com>
> Tested-by: Tamir Winetroub <tamirw@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied, thanks Jiri.