netdev - Re: [PATCH net] virtio_net: reject XDP programs using header adjustment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJpBn1yCHOLRYs2p4-YBYG5q3omynWkB7=5ZvoND_ULhHNv0Qw@mail.gmail.com>
Date:   Mon, 19 Dec 2016 15:42:24 +0000
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     "Mintz, Yuval" <Yuval.Mintz@...ium.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "kafai@...com" <kafai@...com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "alexei.starovoitov@...il.com" <alexei.starovoitov@...il.com>,
        "mst@...hat.com" <mst@...hat.com>
Subject: Re: [PATCH net] virtio_net: reject XDP programs using header adjustment

On Mon, Dec 19, 2016 at 3:23 PM, Mintz, Yuval <Yuval.Mintz@...ium.com> wrote:
>> commit 17bedab27231 ("bpf: xdp: Allow head adjustment in XDP prog")
>> added a new XDP helper to prepend and remove data from a frame.
>> Make virtio_net reject programs making use of this helper until proper
>> support is added.
>>
>> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>
> Is that how it goes until we'll add the proper infrastructure?
> Am I expected to provide the same for qede?

I asked Martin to fix the existing drivers like qede but virtio's XDP
was not merged at that point.

> I was under the impression that so long as this is being [early] developed
> and there's no way to communicate what is and isn't supported by
> a given implementation, it would simply be the user's responsibility
> to make sure what he's trying is supported.

IMHO the less user has to guess the better if we're hoping for wide adoption.