netdev - RE: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM4PR04MB16044EBA36B62CBA1CEB5C96EC910@AM4PR04MB1604.eurprd04.prod.outlook.com>
Date:   Mon, 19 Dec 2016 16:07:45 +0000
From:   Madalin-Cristian Bucur <madalin.bucur@....com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Scott Wood <scott.wood@....com>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>
Subject: RE: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[]

> From: David Miller [mailto:davem@...emloft.net]
> Sent: Monday, December 19, 2016 5:37 PM
> 
> From: Madalin Bucur <madalin.bucur@....com>
> Date: Mon, 19 Dec 2016 11:22:20 +0200
> 
> > The fsl/fman drivers will use of_platform_populate() on all
> > supported platforms.
> >
> > Signed-off-by: Madalin Bucur <madalin.bucur@....com>
> 
> It seems that this creates a failure point between patches #2 and
> #3.  If the cases handled by this "fsl,fman" entry are only afterwards
> covered by the of_platform_populate() code added in patch #3 then you
> cannot split these two changes up like this.
> 
> The two changes must be done at the same time, otherwise probing will
> fail for some people between patches #2 and #3.

You are right, that will happen. I was not convinced these need to be
merged due to the different places they touch. I'll send a v3.