netdev - Re: [PATCH net] be2net: Increase skb headroom size to 256 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161220.143032.511618714729371345.davem@davemloft.net>
Date:   Tue, 20 Dec 2016 14:30:32 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     suresh.reddy@...adcom.com
Cc:     netdev@...r.kernel.org, kalesh-anakkur.purayil@...adcom.com
Subject: Re: [PATCH net] be2net: Increase skb headroom size to 256 bytes

From: Suresh Reddy <suresh.reddy@...adcom.com>
Date: Tue, 20 Dec 2016 10:14:30 -0500

> From: Kalesh A P <kalesh-anakkur.purayil@...adcom.com>
> 
> The driver currently allocates 128 bytes of skb headroom.
> This was found to be insufficient with some configurations
> like Geneve tunnels, which resulted in skb head reallocations.
> 
> Increase the headroom to 256 bytes to fix this.
> 
> Signed-off-by: Kalesh A P <kalesh-anakkur.purayil@...adcom.com>
> Signed-off-by: Suresh Reddy <suresh.reddy@...adcom.com>

Adding 128 bytes of headroom just for geneve seems excessive.

Do you really need to add that much?