netdev - Re: [PATCH net] netfilter: check duplicate config when initializing in ipt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_e=cOyhVzWbrPM6E135iqAOP5gPdaXCoUBK8HE-dop+Xg@mail.gmail.com>
Date:   Tue, 20 Dec 2016 19:14:28 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     network dev <netdev@...r.kernel.org>,
        netfilter-devel@...r.kernel.org, davem <davem@...emloft.net>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [PATCH net] netfilter: check duplicate config when initializing
 in ipt_CLUSTERIP

On Tue, Dec 20, 2016 at 8:48 AM, Pablo Neira Ayuso <pablo@...filter.org> wrote:
> On Thu, Dec 15, 2016 at 12:31:40PM +0800, Xin Long wrote:
>> @@ -185,6 +186,17 @@ clusterip_config_init(const struct ipt_clusterip_tgt_info *i, __be32 ip,
>>       atomic_set(&c->refcount, 1);
>>       atomic_set(&c->entries, 1);
>>
>> +     spin_lock_bh(&cn->lock);
>> +     if (__clusterip_config_find(net, ip)) {
>> +             spin_unlock_bh(&cn->lock);
>> +             kfree(c);
>> +
>> +             return NULL;
>> +     }
>
> This is going to result in ENOMEM error report to userspace on race,
> which can be confusing. Time for clusterip_config_init() to return
> PTR_ERR()?
will post v2 with PTR_ERR, thanks.

>
>> +
>> +     list_add_rcu(&c->list, &cn->configs);
>> +     spin_unlock_bh(&cn->lock);
>> +
>>  #ifdef CONFIG_PROC_FS
>>       {
>>               char buffer[16];