netdev - Re: [PATCH net] openvswitch: Add a missing break statement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0A15F181-0203-4A3E-B03F-4B3D2313C1B9@ovn.org>
Date:   Mon, 19 Dec 2016 17:10:07 -0800
From:   Jarno Rajahalme <jarno@....org>
To:     Jarno Rajahalme <jarno@....org>
Cc:     netdev@...r.kernel.org, jbenc@...hat.com, pshelar@....org
Subject: Re: [PATCH net] openvswitch: Add a missing break statement.

> On Dec 19, 2016, at 5:06 PM, Jarno Rajahalme <jarno@....org> wrote:
> 
> Add a break statement to prevent fall-through from
> OVS_KEY_ATTR_ETHERNET to OVS_KEY_ATTR_TUNNEL.  Without the break
> actions setting ethernet addresses fail to validate with log messages
> complaining about invalid tunnel attributes.
> 
> Fixes: 0a6410fbde ("openvswitch: netlink: support L3 packets")
> Signed-off-by: Jarno Rajahalme <jarno@....org>
> Acked-by: Pravin B Shelar <pshelar@....org>
> Acked-by: Jiri Benc <jbenc@...hat.com>
> ---
> net/openvswitch/flow_netlink.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
> index d19044f..c87d359 100644
> --- a/net/openvswitch/flow_netlink.c
> +++ b/net/openvswitch/flow_netlink.c
> @@ -2195,6 +2195,7 @@ static int validate_set(const struct nlattr *a,
> 	case OVS_KEY_ATTR_ETHERNET:
> 		if (mac_proto != MAC_PROTO_ETHERNET)
> 			return -EINVAL;
> +		break;
> 
> 	case OVS_KEY_ATTR_TUNNEL:
> 		if (masked)
> -- 
> 2.1.4
> 

I posted this separately from an earlier net-next patch series. Pravin agreed to pick up that rest of the series (skb->protocol w/ vlans).

  Jarno