netdev - Re: [PATCH] net: macb: Applied changes according to review made by Andy Shevchenko.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161221.110856.890610349232988869.davem@davemloft.net>
Date:   Wed, 21 Dec 2016 11:08:56 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     bfolta@...ence.com
Cc:     nicolas.ferre@...el.com, niklas.cassel@...s.com,
        alexandre.torgue@...com, satananda.burla@...iumnetworks.com,
        rvatsavayi@...iumnetworks.com, simon.horman@...ronome.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        rafalo@...ence.com
Subject: Re: [PATCH] net: macb: Applied changes according to review made by
 Andy Shevchenko.

From: Bartosz Folta <bfolta@...ence.com>
Date: Wed, 21 Dec 2016 08:53:05 +0000

> This patch is sent in regard to recently applied patch
> Commit 83a77e9ec4150ee4acc635638f7dedd9da523a26
> net: macb: Added PCI wrapper for Platform Driver.
> Andy's review does not appear on mailing lists. I can't reference it.
> 
> Signed-off-by: Bartosz Folta <bfolta@...ence.com>

This commit log message and Subject line need a lot of improvement.

You should be saying what exactly you are doing, rather than "someone
said I should do this".  The latter gives the reader no information
whatsoever about what the patch is doing.