netdev - Re: [PATCH net] net: ipv4: Don't crash if passing a null sk to ip_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161222.111356.512268808563371509.davem@davemloft.net>
Date:   Thu, 22 Dec 2016 11:13:56 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     lorenzo@...gle.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net: ipv4: Don't crash if passing a null sk to
 ip_do_redirect.

From: Lorenzo Colitti <lorenzo@...gle.com>
Date: Fri, 23 Dec 2016 00:33:57 +0900

> Commit e2d118a1cb5e ("net: inet: Support UID-based routing in IP
> protocols.") made ip_do_redirect call sock_net(sk) to determine
> the network namespace of the passed-in socket. This crashes if sk
> is NULL.
> 
> Fix this by getting the network namespace from the skb instead.
> 
> Fixes: e2d118a1cb5e ("net: inet: Support UID-based routing in IP protocols.")
> Signed-off-by: Lorenzo Colitti <lorenzo@...gle.com>

Applied, thanks Lorenzo.