netdev - RE: [PATCH v3 net-next] bnx2x: ethtool -x support for rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BY2PR07MB2309A45B4840D485F98148FA8D970@BY2PR07MB2309.namprd07.prod.outlook.com>
Date:   Sun, 25 Dec 2016 11:36:53 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
CC:     David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: RE: [PATCH v3 net-next] bnx2x: ethtool -x support for rss_key

 +	if (key) {
> +		WARN_ON_ONCE(bnx2x_get_rxfh_key_size(dev) !=
> T_ETH_RSS_KEY * 4);
> +		bnx2x_get_rss_key(&bp->rss_conf_obj, key);
> +	}

This doesn’t work VFs [the PF has the RSS configuration object in their
case; They don't have it], which is fine as 'key' should never be set for
them [since you're adding bnx2x_get_rxfh_key_size() to ethtool ops
only for PFs]. But this probably still worth a comment, though.

> -	memcpy(rss.rss_key, rss_tlv->rss_key, sizeof(rss_tlv->rss_key));
> +	memcpy(&vf->rss_conf_obj.rss_key, rss_tlv->rss_key,
> +sizeof(rss_tlv->rss_key));
>  	rss.rss_obj = &vf->rss_conf_obj;
>  	rss.rss_result_mask = rss_tlv->rss_result_mask;

The change you've applied in bnx2x_setup_rss() should affect here
as well, meaning the PF would copy the parameters into the PF's RSS
configuration object belonging to the VF from the parameter.

This change would cause the PF to configure the VF's RSS key
as all-zeros [as parameters were initially zeroed].