netdev - Re: [PATCH net] net: korina: Fix NAPI versus resources freeing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161226.112636.2130782607738208283.davem@davemloft.net>
Date:   Mon, 26 Dec 2016 11:26:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, alex@....com, phil@....cc
Subject: Re: [PATCH net] net: korina: Fix NAPI versus resources freeing

From: Florian Fainelli <f.fainelli@...il.com>
Date: Fri, 23 Dec 2016 19:56:56 -0800

> Commit beb0babfb77e ("korina: disable napi on close and restart")
> introduced calls to napi_disable() that were missing before,
> unfortunately this leaves a small window during which NAPI has a chance
> to run, yet we just freed resources since korina_free_ring() has been
> called:
> 
> Fix this by disabling NAPI first then freeing resource, and make sure
> that we also cancel the restart taks before doing the resource freeing.
> 
> Fixes: beb0babfb77e ("korina: disable napi on close and restart")
> Reported-by: Alexandros C. Couloumbis <alex@....com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks.