netdev - Re: [PATCH v1] net: dev_weight: TX/RX orthogonality,Re: [PATCH v1] net: dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161226.115818.1691666598003246082.davem@davemloft.net>
Date:   Mon, 26 Dec 2016 11:58:18 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     matthias.tafelmeier@....net
Cc:     netdev@...r.kernel.org, hagen@...u.net, fw@...len.de,
        edumazet@...gle.com, daniel@...earbox.net
Subject: Re: [PATCH v1] net: dev_weight: TX/RX orthogonality,Re: [PATCH v1]
 net: dev_weight: TX/RX orthogonality

From: Matthias Tafelmeier <matthias.tafelmeier@....net>
Date: Mon, 26 Dec 2016 17:43:08 +0100

> 
>> From: Matthias Tafelmeier <matthias.tafelmeier@....net>
>> Date: Mon, 26 Dec 2016 10:49:23 +0100
>>
>>> @@ -269,13 +269,21 @@ static struct ctl_table net_core_table[] = {
>>>  		.extra1		= &min_rcvbuf,
>>>  	},
>>>  	{
>>> -		.procname	= "dev_weight",
>>> -		.data		= &weight_p,
>>> +		.procname	= "dev_weight_rx",
>>> +		.data		= &weight_p_rx,
>>  ...
>>>  	{
>>> +		.procname	= "dev_weight_tx",
>> Sysctls are user visible APIs.  You cannot change them without
>> breaking userspace.  You particularly cannot change the name of
>> the sysctl.
> 
> What about leaving *dev_weight* in place for TX side as is and newly
> introducing a sysctl param
> *dev_weight_rx*. Though, am open to a better naming for the latter.

This changes behavior for existing users, you cannot do this.