lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Dec 2016 13:15:02 -0800 From: David Dillow <dave@...dillows.org> To: Thomas Preisner <thomas.preisner+linux@....de> Cc: sergei.shtylyov@...entembedded.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-kernel@...cs.fau.de, milan.stephan+linux@....de Subject: Re: Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote: > Those spaces were actually left out purposely: The file in question (typhoon.c) > is missing those spaces between the statements (if, for, while) and the > following opening bracket pretty much always (except 2-3 times) and we figured > that it might be better to keep the coding style consistent since this might > aswell have been intended by the original author. I'm not sure if we had the rule back then, or if I just missed it. Either way, we should follow the rules for new code if we can. I'm not sure it's worth fixing all of the instances -- usually formatting-only changes are not worth the churn -- but I don't have a strong opinion on the matter.
Powered by blists - more mailing lists