netdev - Re: [PATCH net-next RESEND 1/1] driver: ipvlan: Remove unnecessary ipvlan NULL check in ipvlan_count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Dec 2016 14:24:53 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     fgao@...ai8.com
Cc:     maheshb@...gle.com, edumazet@...gle.com, netdev@...r.kernel.org,
        gfree.wind@...il.com
Subject: Re: [PATCH net-next RESEND 1/1] driver: ipvlan: Remove unnecessary
 ipvlan NULL check in ipvlan_count_rx

From: fgao@...ai8.com
Date: Wed, 28 Dec 2016 16:47:42 +0800

> From: Gao Feng <fgao@...ai8.com>
> 
> There are three functions which would invoke the ipvlan_count_rx. They
> are ipvlan_process_multicast, ipvlan_rcv_frame, and ipvlan_nf_input.
> The former two functions already use the ipvlan directly before
> ipvlan_count_rx, and ipvlan_nf_input gets the ipvlan from
> ipvl_addr->master, it is not possible to be NULL too.
> So the ipvlan pointer check is unnecessary in ipvlan_count_rx.
> 
> Signed-off-by: Gao Feng <fgao@...ai8.com>

Applied.