lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <01df94bb-6f31-1fea-50a2-3f0136b969cc@texas.net> Date: Tue, 27 Dec 2016 21:24:35 -0800 From: David VomLehn <vomlehn@...as.net> To: Rami Rosen <roszenrami@...il.com> Cc: Netdev <netdev@...r.kernel.org>, Simon Edelhaus <Simon.Edelhaus@...antia.com>, Dmitrii Tarakanov <Dmitrii.Tarakanov@...antia.com>, Alexander Loktionov <Alexander.Loktionov@...antia.com> Subject: Re: [PATCH 01/12] Make and configuration files. On 12/27/2016 08:47 PM, Rami Rosen wrote: > Hi, David, > > For the Makefile, you should follow the pattern which is common in > Linux Kernel Ethernet drivers, for example, > http://lxr.free-electrons.com/source/drivers/net/ethernet/intel/i40e/Makefile or > http://lxr.free-electrons.com/source/drivers/net/ethernet/mellanox/mlx5/core/Makefile > > > Don't think that I ever saw usage of "-j" in a kernel module Makefile; > apart from it, "-j4" is specific to one platform with a given number > of cores, and of course there can be platforms with many more cores, > for which it is less suitable. You can pass the "-j" when running > "make" from the command line, there is no justification to put it in a > Makefile: > >> +all: >> + $(MAKE) -j4 CC=$(CC) -C $(BUILD_DIR) M=$(PWD) modules >> + >> +dox: .doxygen >> + @doxygen $< >> + >> +clean: >> + $(MAKE) -j4 -C $(BUILD_DIR) M=$(PWD) clean > Don't think I ever encountered load/unload targets in Linux Kernel > Makefiles (not talking about out of tree projects): > >> +load: >> + insmod ./$(TARGET).ko >> + >> +unload: >> + rmmod ./$(TARGET).ko > > Regards, > Rami Rosen You are right. The driver spent a while as an out-of-tree build module, where this made sense. It clearly no longer makes sense. -- David VL
Powered by blists - more mailing lists