netdev - Re: [PATCH] skfp: hwmtm: Use proper logging macros, correct mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161227.201706.1509861992180599997.davem@davemloft.net>
Date:   Tue, 27 Dec 2016 20:17:06 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     joe@...ches.com
Cc:     colin.king@...onical.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] skfp: hwmtm: Use proper logging macros, correct
 mismatches

From: Joe Perches <joe@...ches.com>
Date: Wed, 21 Dec 2016 16:41:52 -0800

> Logging macros should allow format and argument validation.
> The DB_TX, DB_RX, and DB_GEN macros did not.
> 
> Update the macros and uses and add no_printk validation to the
> previously compiled away #ifndef DEBUG variants.
> 
> Done with coccinelle and some typing.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied.