netdev - Re: [PATCH] sh_eth: fix branch prediction in sh_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161229.221622.1861506744608931336.davem@davemloft.net>
Date:   Thu, 29 Dec 2016 22:16:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sergei.shtylyov@...entembedded.com
Cc:     netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        ben.hutchings@...ethink.co.uk
Subject: Re: [PATCH] sh_eth: fix branch prediction in sh_eth_interrupt()

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Fri, 30 Dec 2016 00:07:38 +0300

> IIUC, likely()/unlikely() should apply to the whole *if* statement's
> expression, not a part of it  -- fix such expression in  sh_eth_interrupt()
> accordingly...
> 
> Fixes: 283e38db65e7 ("sh_eth: Fix serialisation of interrupt disable with interrupt & NAPI handlers")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> 
> ---
> The patch is against DaveM's 'net-next.git' repo; I'm not sure if it should
> be  targeted to the 'net.git' repo instead...

I decided to apply this to 'net', thanks.