netdev - Re: [net-next 15/21] ixgbe: Configure advertised speeds correctly for KR/KX backplane

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a268273-d95d-16b4-a6a4-653caad791e9@cogentembedded.com>
Date:   Fri, 30 Dec 2016 14:01:47 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net
Cc:     Don Skidmore <donald.c.skidmore@...el.com>, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com,
        guru.anbalagane@...cle.com
Subject: Re: [net-next 15/21] ixgbe: Configure advertised speeds correctly for
 KR/KX backplane

Hello.

On 12/30/2016 12:33 PM, Jeff Kirsher wrote:

> From: Don Skidmore <donald.c.skidmore@...el.com>
>
> This patch ensures that the advertised link speeds are configured
> for X553 KR/KX backplane.  Without this patch the link remains at
> 1G when resuming form low power after being downshifted by LPLU.
>
> Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
> index 92f2b5e..675c198 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
> @@ -2187,12 +2187,11 @@ static s32 ixgbe_setup_kx4_x550em(struct ixgbe_hw *hw)
>  /**
>   * ixgbe_setup_kr_x550em - Configure the KR PHY
>   * @hw: pointer to hardware structure
> - *
> - * Configures the integrated KR PHY for X550EM_x.
>   **/
>  static s32 ixgbe_setup_kr_x550em(struct ixgbe_hw *hw)
>  {
> -	if (hw->mac.type != ixgbe_mac_X550EM_x)
> +	/* leave linke alone for 2.5G */

    Link, maybe?

> +	if (hw->phy.autoneg_advertised & IXGBE_LINK_SPEED_2_5GB_FULL)
>  		return 0;
>
>  	return ixgbe_setup_kr_speed_x550em(hw, hw->phy.autoneg_advertised);

MBR, Sergei