lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <6434425.l4ZxB6kK6L@wuerfel> Date: Sat, 31 Dec 2016 21:23:58 +0100 From: Arnd Bergmann <arnd@...db.de> To: Florian Fainelli <f.fainelli@...il.com> Cc: Greentime Hu <green.hu@...il.com>, netdev@...r.kernel.org, devicetree@...r.kernel.org, andrew@...n.ch, linux-kernel@...r.kernel.org, jiri@...nulli.us Subject: Re: [PATCH v3] net: ethernet: faraday: To support device tree usage. On Saturday, December 31, 2016 10:48:39 AM CET Florian Fainelli wrote: > > On 12/29/2016 11:37 PM, Greentime Hu wrote: > > Signed-off-by: Greentime Hu <green.hu@...il.com> > > This is not enough, you need to add a Device Tree binding document under > Documentation/devicetree/bindings/net/ which documents this compatible > string, as well as additional properties that may be required to > describe this hardware block. We already have Documentation/devicetree/bindings/net/moxa,moxart-mac.txt for the same hardware (though used by a different driver). I'd suggest renaming that one to a more generic file name and adding the new compatible string there. Aside from that, every patch should also have a changelog comment. Arnd
Powered by blists - more mailing lists