lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20161231.123635.849464145094515334.davem@davemloft.net> Date: Sat, 31 Dec 2016 12:36:35 -0500 (EST) From: David Miller <davem@...emloft.net> To: ebiggers3@...il.com Cc: netdev@...r.kernel.org, lorenzo@...gle.com, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, ebiggers@...gle.com Subject: Re: [PATCH] net: socket: don't set sk_uid to garbage value in ->setattr() From: Eric Biggers <ebiggers3@...il.com> Date: Fri, 30 Dec 2016 17:42:32 -0600 > From: Eric Biggers <ebiggers@...gle.com> > > ->setattr() was recently implemented for socket files to sync the socket > inode's uid to the new 'sk_uid' member of struct sock. It does this by > copying over the ia_uid member of struct iattr. However, ia_uid is > actually only valid when ATTR_UID is set in ia_valid, indicating that > the uid is being changed, e.g. by chown. Other metadata operations such > as chmod or utimes leave ia_uid uninitialized. Therefore, sk_uid could > be set to a "garbage" value from the stack. > > Fix this by only copying the uid over when ATTR_UID is set. > > Fixes: 86741ec25462 ("net: core: Add a UID field to struct sock.") > Signed-off-by: Eric Biggers <ebiggers@...gle.com> Lorenzo, please review.
Powered by blists - more mailing lists