netdev - Re: [PATCH v2 net-next] net:mv88e6xxx: use g2 interrupt for 6097 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170103162815.GC32450@lunn.ch>
Date:   Tue, 3 Jan 2017 17:28:15 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Volodymyr Bendiuga <volodymyr.bendiuga@...il.com>
Cc:     vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, volodymyr.bendiuga@...termo.se
Subject: Re: [PATCH v2 net-next] net:mv88e6xxx: use g2 interrupt for 6097 chip

On Tue, Jan 03, 2017 at 04:18:40PM +0100, Volodymyr Bendiuga wrote:
> From: Volodymyr Bendiuga <volodymyr.bendiuga@...termo.se>
> 
> This chip needs MV88E6XXX_FLAG_G2_INT
> 
> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@...termo.se>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> ---
>  drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> index af54bae..431e954 100644
> --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> @@ -566,6 +566,7 @@ enum mv88e6xxx_cap {
>  	(MV88E6XXX_FLAG_G1_ATU_FID |	\
>  	 MV88E6XXX_FLAG_G1_VTU_FID |	\
>  	 MV88E6XXX_FLAG_GLOBAL2 |	\
> + 	 MV88E6XXX_FLAG_G2_INT |	\

checkpatch is your friend:

$ ./scripts/checkpatch.pl volodymyr.bendiuga 
ERROR: code indent should use tabs where possible
#76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569:
+ ^I MV88E6XXX_FLAG_G2_INT |^I\$

WARNING: please, no space before tabs
#76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569:
+ ^I MV88E6XXX_FLAG_G2_INT |^I\$

WARNING: please, no spaces at the start of a line
#76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569:
+ ^I MV88E6XXX_FLAG_G2_INT |^I\$

total: 1 errors, 2 warnings, 0 checks, 7 lines checked

       Andrew