netdev - Re: [PATCH] Ipvlan should return an error when an address is already in use.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7ta8b87xqc.fsf@redhat.com>
Date:   Tue, 03 Jan 2017 14:24:43 -0500
From:   Aaron Conole <aconole@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     kjlx@...pleofstupid.com, maheshb@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] Ipvlan should return an error when an address is already in use.

David Miller <davem@...emloft.net> writes:

> From: Aaron Conole <aconole@...hat.com>
> Date: Tue, 03 Jan 2017 10:50:00 -0500
>
>>> @@ -489,7 +490,12 @@ static int __inet_insert_ifa(struct in_ifaddr *ifa, struct nlmsghdr *nlh,
>>>  	   Notifier will trigger FIB update, so that
>>>  	   listeners of netlink will know about new ifaddr */
>>>  	rtmsg_ifa(RTM_NEWADDR, ifa, nlh, portid);
>>> -	blocking_notifier_call_chain(&inetaddr_chain, NETDEV_UP, ifa);
>>> +	ret = blocking_notifier_call_chain(&inetaddr_chain, NETDEV_UP, ifa);
>> 
>> Why are you doing this assignment if you aren't using the result?
>> 
>>> +	ret = notifier_to_errno(ret);
>>> +	if (ret) {
>>> +		__inet_del_ifa(in_dev, ifap, 1, NULL, portid);
>>> +		return ret;
>>> +	}
>
> 'ret' assignment is being used, via notifier_to_errno().

d'oh!  should have had more coffee - sorry for the noise.