netdev - RE: [PATCH v2] scm: fix possible control message header alignment issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8729016553E3654398EA69218DA29EEF15A4CA6B@cnshjmbx04>
Date:   Tue, 3 Jan 2017 00:52:37 +0000
From:   YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "cugyly@....com" <cugyly@....com>
Subject: RE: [PATCH v2] scm: fix possible control message header alignment
 issue



> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Saturday, December 31, 2016 4:21 AM
> To: cugyly@....com
> Cc: netdev@...r.kernel.org; YUAN Linyu
> Subject: Re: [PATCH v2] scm: fix possible control message header alignment
> issue
> If you can come up with a case where this does happen in
> practice, I will continue to consider this patch.
> 
Yes, before send patch I also check two archs(arm-v7 and powerpc e6500), they are aligned.
No one report issue, I think cmsghdr aligned on all archs.

> Otherwise, we should make the assumptions that exist explicit
> and get rid of all of the code that does that funny alignment
> upon the cmsghdr structure.
> 
Do you accept that I remove all CMSG{_COMPAT}_ALIGN of header ?

> Thanks.