netdev - Re: [PATCH net-next V3 3/3] tun: rx batching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52dd7224-d26e-7684-214e-0d8289392ff3@redhat.com>
Date:   Tue, 3 Jan 2017 11:18:17 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     mst@...hat.com, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        wexu@...hat.com
Subject: Re: [PATCH net-next V3 3/3] tun: rx batching



On 2017年01月01日 05:03, Stephen Hemminger wrote:
> On Fri, 30 Dec 2016 13:20:51 +0800
> Jason Wang <jasowang@...hat.com> wrote:
>
>> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
>> index cd8e02c..a268ed9 100644
>> --- a/drivers/net/tun.c
>> +++ b/drivers/net/tun.c
>> @@ -75,6 +75,10 @@
>>   
>>   #include <linux/uaccess.h>
>>   
>> +static int rx_batched;
>> +module_param(rx_batched, int, 0444);
>> +MODULE_PARM_DESC(rx_batched, "Number of packets batched in rx");
>> +
>>   /* Uncomment to enable debugging */
> I like the concept or rx batching. But controlling it via a module parameter
> is one of the worst API choices.  Ethtool would be better to use because that is
> how other network devices control batching.
>
> If you do ethtool, you could even extend it to have an number of packets
> and max latency value.

Right, this is better (I believe you mean rx-frames). For rx-usecs, we 
could do it on top in the future.

Thanks