netdev - Re: [PATCH] uapi: use wildcards to list files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2108827.WpE3IvfEdH@wuerfel>
Date:   Tue, 03 Jan 2017 22:37:04 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, netdev@...r.kernel.org,
        linux-media@...r.kernel.org, linux-mmc@...r.kernel.org,
        netfilter-devel@...r.kernel.org, linux-nfs@...r.kernel.org,
        linux-raid@...r.kernel.org, linux-spi@...r.kernel.org,
        linux-mtd@...ts.infradead.org, linux-rdma@...r.kernel.org,
        fcoe-devel@...n-fcoe.org, alsa-devel@...a-project.org,
        linux-fbdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
        davem@...emloft.net, airlied@...ux.ie,
        David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] uapi: use wildcards to list files

On Tuesday, January 3, 2017 3:35:44 PM CET Nicolas Dichtel wrote:
> Regularly, when a new header is created in include/uapi/, the developer
> forgets to add it in the corresponding Kbuild file. This error is usually
> detected after the release is out.
> 
> In fact, all headers under include/uapi/ should be exported, so let's
> use wildcards.

I think the idea makes a lot of sense: if a header is in uapi, we should
really export it. However, using a wildcard expression seems a bit
backwards here, I think we should make this implicit and not have the
Kbuild file at all.

The "header-y" syntax was originally added back when the uapi headers
were mixed with the internal headers in the same directory. After
David Howells introduced the separate directory for uapi, it has
become a bit redundant.

Can you try to modify scripts/Makefile.headersinst instead so we
can simply remove the Kbuild files entirely?

	Arnd