netdev - Re: [PATCH net] sfc: don't report RX hash keys to ethtool when RSS wasn't enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 04 Jan 2017 14:18:31 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ecree@...arflare.com
Cc:     linux-net-drivers@...arflare.com, bkenward@...arflare.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] sfc: don't report RX hash keys to ethtool when RSS
 wasn't enabled

From: Edward Cree <ecree@...arflare.com>
Date: Wed, 4 Jan 2017 15:10:56 +0000

> If we failed to set up RSS on EF10 (e.g. because firmware declared
>  RX_RSS_LIMITED), ethtool --show-nfc $dev rx-flow-hash ... should report
>  no fields, rather than confusingly reporting what fields we _would_ be
>  hashing on if RSS was working.
> 
> Fixes: dcb4123cbec0 ("sfc: disable RSS when unsupported")
> Signed-off-by: Edward Cree <ecree@...arflare.com>

Applied.