netdev - Re: [PATCH net-next 0/6] Prepare BPF for VLAN_TAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170104213024.sghqhqfbzqfl4z47@rere.qmqm.pl>
Date:   Wed, 4 Jan 2017 22:30:24 +0100
From:   Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     netdev@...r.kernel.org, alexei.starovoitov@...il.com
Subject: Re: [PATCH net-next 0/6] Prepare BPF for VLAN_TAG_PRESENT cleanup

On Wed, Jan 04, 2017 at 09:11:57PM +0100, Daniel Borkmann wrote:
> On 01/04/2017 02:18 AM, Michał Mirosław wrote:
> > Those patches prepare BPF ant its JITs for removal of VLAN_TAG_PRESENT.
> > The set depends on "Preparation for VLAN_TAG_PRESENT cleanup" patchset.
> > 
> > The series is supposed to be bisect-friendly and that requires temporary
> > insertion of #define VLAN_TAG_PRESENT in BPF code to be able to split
> > JIT changes per architecture.
> > 
> > Michał Mirosław (6):
> >    net/skbuff: add macros for VLAN_PRESENT bit
> >    net/bpf_jit: ARM: split VLAN_PRESENT bit handling from VLAN_TCI
> >    net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI
> >    net/bpf_jit: PPC: split VLAN_PRESENT bit handling from VLAN_TCI
> >    net/bpf_jit: SPARC: split VLAN_PRESENT bit handling from VLAN_TCI
> >    net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI
> 
> Please add a proper changelog to all the individual patches, right now
> they have none. Also, how was this runtime tested? Did you run BPF selftest
> suite with them? Seems like they weren't even compile tested properly
> given the kbuild bot barking on sparc ...

Compile bot is barking because it doesn't have patches, which this set depends on.
Sorry about that.

Best Regards,
Michał Mirosław