netdev - Re: [PATCH net-next 2/2] net:dsa: check for EPROBE_DEFER from dsa_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170104021948.GB10768@lunn.ch>
Date:   Wed, 4 Jan 2017 03:19:48 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Volodymyr Bendiuga <volodymyr.bendiuga@...termo.se>
Cc:     vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        davem@...emloft.net, netdev@...r.kernel.org,
        volodymyr.bendiuga@...il.com
Subject: Re: [PATCH net-next 2/2] net:dsa: check for EPROBE_DEFER from
 dsa_dst_parse()

On Wed, Dec 07, 2016 at 05:56:06PM +0100, Volodymyr Bendiuga wrote:
> Since there can be multiple dsa switches stacked together but
> not all of devicetree nodes available at the time of calling
> dsa_dst_parse(), EPROBE_DEFER can be returned by it. When this
> happens, only the last dsa switch has to be deleted by
> dsa_dst_del_ds(), but not the whole list, because next time linux
> cames back to this function it will try to add only the last dsa
> switch which returned EPROBE_DEFER.
> 
> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@...termo.se>
> ---
>  net/dsa/dsa2.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
> index 7924c92..0a5ddaa 100644
> --- a/net/dsa/dsa2.c
> +++ b/net/dsa/dsa2.c
> @@ -673,8 +673,14 @@ static int _dsa_register_switch(struct dsa_switch *ds, struct device_node *np)
>  	}
>  
>  	err = dsa_dst_parse(dst);
> -	if (err)
> +	if (err){
> +		if (-EPROBE_DEFER == err) {

Hi Volodymyr

Please can you turn this around, err == -EPROBE_DEFER, to make it
consistent with all the other network code.

With that change

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew