netdev - Re: [PATCH net-next] ibmvnic: fix accelerated VLAN handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201701041053.qocuoupG%fengguang.wu@intel.com>
Date:   Wed, 4 Jan 2017 10:36:48 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>,
        John Allen <jallen@...ux.vnet.ibm.com>
Subject: Re: [PATCH net-next] ibmvnic: fix accelerated VLAN handling

Hi Michał,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Micha-Miros-aw/ibmvnic-fix-accelerated-VLAN-handling/20170104-095210
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_xmit':
>> drivers/net/ethernet/ibm/ibmvnic.c:768:40: error: implicit declaration of function 'skb_vlan_tag_present' [-Werror=implicit-function-declaration]
     if (adapter->vlan_header_insertion && skb_vlan_tag_present(skb)) {
                                           ^~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_poll':
>> drivers/net/ethernet/ibm/ibmvnic.c:968:4: error: implicit declaration of function '__vlan_hwaccel_put_tag' [-Werror=implicit-function-declaration]
       __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), be16_to_cpu(next->rx_comp.vlan_tci));
       ^~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/skb_vlan_tag_present +768 drivers/net/ethernet/ibm/ibmvnic.c

   762		tx_crq.v1.flags1 = IBMVNIC_TX_COMP_NEEDED;
   763		tx_crq.v1.correlator = cpu_to_be32(index);
   764		tx_crq.v1.dma_reg = cpu_to_be16(tx_pool->long_term_buff.map_id);
   765		tx_crq.v1.sge_len = cpu_to_be32(skb->len);
   766		tx_crq.v1.ioba = cpu_to_be64(data_dma_addr);
   767	
 > 768		if (adapter->vlan_header_insertion && skb_vlan_tag_present(skb)) {
   769			tx_crq.v1.flags2 |= IBMVNIC_TX_VLAN_INSERT;
   770			tx_crq.v1.vlan_id = cpu_to_be16(skb->vlan_tci);
   771		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (51750 bytes)