netdev - Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170104.235105.547654899088862054.davem@davemloft.net>
Date:   Wed, 04 Jan 2017 23:51:05 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     daniel@...earbox.net
Cc:     sowmini.varadhan@...cle.com, willemb@...gle.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp
 on tpacket_v3 in tx mode

From: Daniel Borkmann <daniel@...earbox.net>
Date: Thu,  5 Jan 2017 02:34:28 +0100

> When TX timestamping is in use with TPACKET_V3's TX ring, then we'll
> hit the BUG() in __packet_set_timestamp() when ring buffer slot is
> returned to user space via tpacket_destruct_skb(). This is due to v3
> being assumed as unreachable here, but since 7f953ab2ba46 ("af_packet:
> TX_RING support for TPACKET_V3") it's not anymore. Fix it by filling
> the timestamp back into the ring slot.
> 
> Fixes: 7f953ab2ba46 ("af_packet: TX_RING support for TPACKET_V3")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Applied, thanks.