netdev - Re: [PATCH nf-next 4/4] netfilter: merge ctinfo into nfct pointer storage area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201701051342.oqwOKzMG%fengguang.wu@intel.com>
Date:   Thu, 5 Jan 2017 14:03:05 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Florian Westphal <fw@...len.de>
Cc:     kbuild-all@...org, netfilter-devel@...r.kernel.org,
        netdev@...r.kernel.org, Florian Westphal <fw@...len.de>
Subject: Re: [PATCH nf-next 4/4] netfilter: merge ctinfo into nfct pointer
 storage area

Hi Florian,

[auto build test WARNING on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-skbuff-merge-nfctinfo-bits-and-nfct-pointer/20170105-133727
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: x86_64-randconfig-x002-201701 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   net/ipv4/netfilter/nf_defrag_ipv4.c: In function 'ipv4_conntrack_defrag':
>> net/ipv4/netfilter/nf_defrag_ipv4.c:78:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if (skb->_nfct && !nf_ct_is_template((struct nf_conn *) skb_nfct(skb)));
     ^~
   net/ipv4/netfilter/nf_defrag_ipv4.c:79:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
      return NF_ACCEPT;
      ^~~~~~

vim +/if +78 net/ipv4/netfilter/nf_defrag_ipv4.c

    62	}
    63	
    64	static unsigned int ipv4_conntrack_defrag(void *priv,
    65						  struct sk_buff *skb,
    66						  const struct nf_hook_state *state)
    67	{
    68		struct sock *sk = skb->sk;
    69	
    70		if (sk && sk_fullsock(sk) && (sk->sk_family == PF_INET) &&
    71		    inet_sk(sk)->nodefrag)
    72			return NF_ACCEPT;
    73	
    74	#if IS_ENABLED(CONFIG_NF_CONNTRACK)
    75	#if !IS_ENABLED(CONFIG_NF_NAT)
    76		/* Previously seen (loopback)?  Ignore.  Do this before
    77		   fragment check. */
  > 78		if (skb->_nfct && !nf_ct_is_template((struct nf_conn *) skb_nfct(skb)));
    79			return NF_ACCEPT;
    80	#endif
    81	#endif
    82		/* Gather fragments. */
    83		if (ip_is_fragment(ip_hdr(skb))) {
    84			enum ip_defrag_users user =
    85				nf_ct_defrag_user(state->hook, skb);
    86	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (24700 bytes)