netdev - Re: [PATCH] stmmac: Enable Clause 45 PHYs in GMAC4 (eQOS)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Jan 2017 10:15:40 +0000
From:   Joao Pinto <Joao.Pinto@...opsys.com>
To:     "Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] stmmac: Enable Clause 45 PHYs in GMAC4 (eQOS)

Às 1:37 AM de 1/5/2017, Kweh, Hock Leong escreveu:
>> -----Original Message-----
>> From: Joao Pinto [mailto:Joao.Pinto@...opsys.com]
>> Sent: Wednesday, January 04, 2017 10:36 PM
>> To: davem@...emloft.net
>> Cc: Kweh, Hock Leong <hock.leong.kweh@...el.com>; netdev@...r.kernel.org;
>> Joao Pinto <Joao.Pinto@...opsys.com>
>> Subject: [PATCH] stmmac: Enable Clause 45 PHYs in GMAC4 (eQOS)
>>
>> The eQOS IP Core (best known in stmmac as gmac4) has a register that must be
>> set if using a Clause 45 PHY. If this register is not set, the PHY won't work.
>> This patch will have no impact in setups using Clause 22 PHYs.
>>
>> Signed-off-by: Joao Pinto <jpinto@...opsys.com>
> 
> Hi Joao,
> 
> This is not working on our environment. We are using the 4-ETH-4-MGB-101 plugin card.
> 
> Regards,
> Wilson

Hi Wilson and David,
I am using a different PHY and I only get it detecting the link with that bit
set. Thanks for your feedback, going to dig a bit more!

Joao


> 
>> ---
>>  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
>> b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
>> index b0344c2..676ae3c 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
>> @@ -41,6 +41,7 @@
>>  #define MII_GMAC4_GOC_SHIFT		2
>>  #define MII_GMAC4_WRITE			(1 << MII_GMAC4_GOC_SHIFT)
>>  #define MII_GMAC4_READ			(3 << MII_GMAC4_GOC_SHIFT)
>> +#define MII_CLAUSE45_PHY		(1 << 1)
>>
>>  static int stmmac_mdio_busy_wait(void __iomem *ioaddr, unsigned int
>> mii_addr)  { @@ -125,7 +126,7 @@ static int stmmac_mdio_write(struct
>> mii_bus *bus, int phyaddr, int phyreg,
>>  	value |= (priv->clk_csr << priv->hw->mii.clk_csr_shift)
>>  		& priv->hw->mii.clk_csr_mask;
>>  	if (priv->plat->has_gmac4)
>> -		value |= MII_GMAC4_WRITE;
>> +		value |= MII_GMAC4_WRITE | MII_CLAUSE45_PHY;
>>  	else
>>  		value |= MII_WRITE;
>>
>> --
>> 2.9.3
>