netdev - Re: [PATCH net-next] cxgb4: Synchronize access to mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D457A6F6-246F-4FAF-82BE-E736DA4B3328@chelsio.com>
Date:   Fri, 6 Jan 2017 03:08:25 +0000
From:   Hariprasad S <hariprasad@...lsio.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Casey Leedom <leedom@...lsio.com>,
        Nirranjan Kirubaharan <nirranjan@...lsio.com>,
        "Ganesh GR" <ganeshgr@...lsio.com>
Subject: Re: [PATCH net-next] cxgb4: Synchronize access to mailbox




> On 05-Jan-2017, at 9:35 PM, David Miller <davem@...emloft.net> wrote:
> 
> From: Hariprasad Shenai <hariprasad@...lsio.com>
> Date: Thu,  5 Jan 2017 11:23:10 +0530
> 
>> @@ -844,6 +848,10 @@ struct adapter {
>>    struct work_struct db_drop_task;
>>    bool tid_release_task_busy;
>> 
>> +    /* lock for mailbox cmd list */
>> +    spinlock_t mbox_lock;
>> +    struct mbox_list mlist;
>> +
> ...
>> @@ -4707,6 +4707,9 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>>    spin_lock_init(&adapter->stats_lock);
>>    spin_lock_init(&adapter->tid_release_lock);
>>    spin_lock_init(&adapter->win0_lock);
>> +    spin_lock_init(&adapter->mbox_lock);
>> +
>> +    INIT_LIST_HEAD(&adapter->mbox_list.list);
> 
> It is absolutely impossible that you even compiled this code.

My bad. Looks like I sent wrong patch. I will send V2 for the same.