netdev - Re: [PATCH net-next 2/2] arm: dts: vf610-zii-dev-rev-b: remove ports label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170106224127.GD10626@lunn.ch>
Date:   Fri, 6 Jan 2017 23:41:27 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Uwe Kleine-König <uwe@...ine-koenig.org>
Subject: Re: [PATCH net-next 2/2] arm: dts: vf610-zii-dev-rev-b: remove ports
 label

On Fri, Jan 06, 2017 at 05:00:43PM -0500, Vivien Didelot wrote:
> Now that the "label" property is optional for Ethernet switch ports,
> remove them in the ZII Dev Rev B board DTS.
>
> On a Rev B board, once eth1 is up, this DTS now exposes to userspace:
> 
>     # ip link | grep ': ' | cut -d: -f2
>      lo
>      eth0
>      eth1
>      eth2@...1
>      eth3@...1
>      eth4@...1
>      eth5@...1
>      eth6@...1
>      eth7@...1
>      eth8@...1
>      eth9@...1
>      eth10@...1
>      eth11@...1
>      eth12@...1

It exposes this, this time. Next time, it could be:

      eth0
      eth1@...0
      eth2@...0
      eth3@...0
      eth4@...0
      eth5@...0
      eth6@...0
      eth7@...0
      eth8@...0
      eth9@...0
      eth10@...0
      eth11@...0
      eth12

depending on how the base interfaces enumerate.

We have gone from deterministic names to non-deterministic names for
the switch ports. We now must have udev rules, if we want
deterministic names.

If the names where not deterministic before, i would of agreed to
this. But they are deterministic, set by device tree, and set to match
some physical property of the hardware, generally the label on the
case/PCB.

If somebody were to produce a switch on a PCIe card, or a USB bus,
things then are non-deterministic, and leaving the kernel to assign a
name is O.K. So i think the first patch is O.K, but i don't like this
patch.

	Andrew