netdev - Re: [PATCH net-next 0/4] l2tp: cleanup socket lookup code in l2tp_ip and l2tp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170106.221913.1150017479115532240.davem@davemloft.net>
Date:   Fri, 06 Jan 2017 22:19:13 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     g.nault@...halink.fr
Cc:     netdev@...r.kernel.org, jchapman@...alix.com, celston@...alix.com
Subject: Re: [PATCH net-next 0/4] l2tp: cleanup socket lookup code in
 l2tp_ip and l2tp_ip6

From: Guillaume Nault <g.nault@...halink.fr>
Date: Fri, 6 Jan 2017 20:03:53 +0100

> First three patches remove redundant tests and add missing "const"
> qualifiers.
> 
> Fourth patch splits the conditionals found in __l2tp_ip*_bind_lookup(),
> to make these functions easier to review. In the process, I found that
> some corner cases were still not handled properly. So I've added the
> missing tests in this patch too, because they're pretty simple and the
> whole "if" statements are modified anyway.
> 
> I expect it to be easier to review this way. If not, I can split up
> patch #4, post the missing tests separately to -net, and later repost
> this series as pure cleanup. Just let me know.

Looks good to me, series applied, thanks.