netdev - Re: [PATCH v2 02/12] net: ethernet: aquantia: Common functions and definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 7 Jan 2017 01:29:50 +0100
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Alexander Loktionov <Alexander.Loktionov@...antia.com>,
        netdev@...r.kernel.org, David VomLehn <vomlehn@...as.net>
Cc:     Simon Edelhaus <Simon.Edelhaus@...antia.com>,
        Dmitrii Tarakanov <Dmitrii.Tarakanov@...antia.com>,
        Pavel Belous <Pavel.Belous@...antia.com>
Subject: Re: [PATCH v2 02/12] net: ethernet: aquantia: Common functions and
 definitions

Hi,

On 06.01.2017 09:06, Alexander Loktionov wrote:
> +
> +#define TXT(_T_) #_T_
> +#define TXTTXT(_T_) TXT(_T_)

do you really need these (IMHO ugly) macros? AFAICS you only use them to 
build the driver
version string.
> +
> +#define AQ_CFG_DRV_AUTHOR      "aQuantia"
> +#define AQ_CFG_DRV_DESC        "aQuantia Corporation(R) Network Driver"
> +#define AQ_CFG_DRV_NAME        "aquantia"
> +#define AQ_CFG_DRV_VERSION	TXTTXT(NIC_MAJOR_DRIVER_VERSION)"."\
> +				TXTTXT(NIC_MINOR_DRIVER_VERSION)"."\
> +				TXTTXT(NIC_BUILD_DRIVER_VERSION)"."\
> +				TXTTXT(NIC_REVISION_DRIVER_VERSION)

Regards,
Lino