netdev - Re: [PATCH net] be2net: fix unicast list filling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170107.212740.1226435999696907045.davem@davemloft.net>
Date:   Sat, 07 Jan 2017 21:27:40 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     cera@...a.cz
Cc:     netdev@...r.kernel.org, sathya.perla@...adcom.com,
        ajit.khaparde@...adcom.com, sriharsha.basavapatna@...adcom.com,
        somnath.kotur@...adcom.com
Subject: Re: [PATCH net] be2net: fix unicast list filling

From: Ivan Vecera <cera@...a.cz>
Date: Fri,  6 Jan 2017 21:59:30 +0100

> The adapter->pmac_id[0] item is used for primary MAC address but
> this is not true for adapter->uc_list[0] as is assumed in
> be_set_uc_list(). There are N UC addresses copied first from net_device
> to adapter->uc_list[1..N] and then N UC addresses from
> adapter->uc_list[0..N-1] are sent to HW. So the last UC address is never
> stored into HW and address 00:00:00:00;00:00 (from uc_list[0]) is used
> instead.
> 
> Cc: Sathya Perla <sathya.perla@...adcom.com>
> Cc: Ajit Khaparde <ajit.khaparde@...adcom.com>
> Cc: Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
> Cc: Somnath Kotur <somnath.kotur@...adcom.com>
> Fixes: b717241 be2net: replace polling with sleeping in the FW completion path
> Signed-off-by: Ivan Vecera <cera@...a.cz>

Applied, thanks.